Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy edge function doesn't handle all quadrilateral shape #9

Open
nghiattran opened this issue Feb 2, 2019 · 1 comment
Open

Noisy edge function doesn't handle all quadrilateral shape #9

nghiattran opened this issue Feb 2, 2019 · 1 comment

Comments

@nghiattran
Copy link

I found buildNoisyEdges function couldn't handle this form of quadrilateral because intersections of 2 lines (edge.v0, edge.v1 and edge.d0, edge.d1) will lie outside of their quadrilateral and makes its noisy edge overlap neighboring edges.

u07_l2_t1_text_final_3_files_image001 1

I think this can be solved can restructure this shape into solvable one that you wrote on your blog.

For example:
20190201_212922

Where:
A, B: Voronoi points.
C, D: Delaunay points.
H: intersection of AB and CD.

We can try to reform this ACBD into AC1BD1 before passing it into buildNoisyEdges function. C1 and D1 are intersections of a line that goes through B and AC / AD respectively.

@amitp
Copy link
Owner

amitp commented Feb 11, 2019

Oh interesting. Are you seeing these kinds of quadrilaterals in this version of mapgen2? I think it is possible but I was hoping they would not actually happen.

(Note: I am not working on mapgen2 anymore; it was a project from 2010.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants