You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I was reading the source code of Sentinel, I found that the ProcessorSlotChain obtained varies for different resources. I found that ResourceWrapper overrides the equals and hashcode to get unique chain here.
As you see, there will use the same chain if resources have the same name, even if they are different resource type. But as user, we may use the same name for different resource by accident. Is there any wrong happen with sentinel because of this case?
The define in ClusterNode considers the name and type. Why not consider as the same at ResourceWrapper?
Issue Description
When I was reading the source code of Sentinel, I found that the ProcessorSlotChain obtained varies for different resources. I found that ResourceWrapper overrides the equals and hashcode to get unique chain here.
As you see, there will use the same chain if resources have the same name, even if they are different resource type. But as user, we may use the same name for different resource by accident. Is there any wrong happen with sentinel because of this case?
The define in
ClusterNode
considers the name and type. Why not consider as the same atResourceWrapper
?I'm not sure if my idea is right. If anything wrong, please correct me.
Describe what happened
Describe what you expected to happen
Maybe we need to consider resource type for resourceWrapper when geting chain.
How to reproduce it (as minimally and precisely as possible)
Tell us your environment
Anything else we need to know?
The text was updated successfully, but these errors were encountered: