Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pace-js package is out-of-date #5986

Open
1 of 3 tasks
barkofdelight opened this issue May 22, 2023 · 0 comments
Open
1 of 3 tasks

The pace-js package is out-of-date #5986

barkofdelight opened this issue May 22, 2023 · 0 comments

Comments

@barkofdelight
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:
There are several bugs in the 1.0.2 version of pace-js. One in particular, it overwrites the WebSocket constants so that simple comparisons in established code always fail. The current release 1.2.4 fixes this and (I assume) much more.

Expected behavior:

The value of WebSocket.OPEN should be the integer 1.

Steps to reproduce:

Start the demo at https://www.akveo.com/ngx-admin/themes, open up the JavaScript console and type WebSocket.OPEN.

Related code:

if (this.websocket.readyState === WebSocket.OPEN) {
  // Will never happen
}

Other information:

See pace-js issue here: CodeByZach/pace#261 (comment). (The detail is about a different class getting corrupted, but it's the same reason.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant