Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Edit Default Hotend PID Values Unless PID_PARAMS_PER_HOTEND Enabled #118

Open
NorthernRealities opened this issue Oct 30, 2021 · 0 comments

Comments

@NorthernRealities
Copy link

Hello,

I just came across the app today and it looks very good. There are two ways to specify the default PID values for hotend(s). If the parameter PID_PARAMS_PER_HOTEND is enabled then the values for DEFAULT_Kp_LIST, DEFAULT_Ki_LIST, and DEFAULT_Kd_LIST will be set, allowing one to configure values for each hotend attached to the machine. When PID_PARAMS_PER_HOTEND is disabled, a single value for each of DEFAULT_Kp, DEFAULT_Ki, and DEFAULT_Kd is used for all hotends on the machine.

When using the application if the value of PID_PARAMS_PER_HOTEND is set to the default value of PID_PARAMS_PER_HOTEND then all six entries for above mentioned parameters are greyed out and the user is not able to modify them. By changing the value PID_PARAMS_PER_HOTEND to enabled all six parameters become modifiable. This goes against the logic in the configuration file. If the PID_PARAMS_PER_HOTEND is disabled the later three variables I mentioned are used and, in my opinion, should also be able to be modified. The first three variables should only be changeable if the PID_PARAMS_PER_HOTEND parameter is enabled.

This is really a low priority issue as to modify the parameters all I had to do was change the value of PID_PARAMS_PER_HOTEND to enabled, make the changes I required to the latter three parameters, and then flip the flag back to disabled again. I'm writing this issue as there may be people whom may not think to do that. I also think that this is a low priority issue because not many people probably actually change the values from their default. I only am because I am rebuilding my machine and did the testing.

I've attached an image showing that when the PID_PARAMS_PER_HOTEND is disabled all six parameters are not modifiable but the bottom three should be. The parameters are showing as modified because I had already enabled the flag, modified the values, and then disabled it again.

Screen Shot 2021-10-30 at 11 44 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant