Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix-2.0.x no longer loading as of commit 274934a #104

Open
Pyro-Fox opened this issue Aug 17, 2019 · 3 comments
Open

bugfix-2.0.x no longer loading as of commit 274934a #104

Pyro-Fox opened this issue Aug 17, 2019 · 3 comments
Labels

Comments

@Pyro-Fox
Copy link

I tried to grab the latest Marlin bugfix-2.0.x branch using Marlin-Conf and the UI no longer loads up the config file. I kept stepping back through commits until it worked and can see that it broke after 274934a.

I really don't understand what might be happening other than,
Marlin-Conf works on 179d6c4 from 8/14/2019...
Working

...but totally breaks on the next commit 274934a from 8/16/2019.
Not working

@akaJes
Copy link
Owner

akaJes commented Aug 21, 2019

Hi, the App catch a fail and stops when it was parsed this wrong text

//#defined LULZBOT_TOUCH_UI

this is a two sided issue

  1. wrong comment in the source Configuration.h
  2. prevent this situation and fix the regexp in the line
    https://github.com/akaJes/marlin-config/blob/master/app/mc.js#L37

@akaJes akaJes added the TODO label Aug 21, 2019
@akaJes
Copy link
Owner

akaJes commented Aug 21, 2019

it was marked as typo and fixed in the source here https://github.com/MarlinFirmware/Marlin/blame/bugfix-2.0.x/Marlin/Configuration.h#L2041

@yet-another-average-joe

@akaJes : happy to read you again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants