Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji picker #18

Open
Hoodgail opened this issue Jul 3, 2022 · 8 comments
Open

Add emoji picker #18

Hoodgail opened this issue Jul 3, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@Hoodgail
Copy link

Hoodgail commented Jul 3, 2022

image (6)

Button to trigger a components full of reactions. I'm getting a little bored of using Google to look up "laughing emoji" to send to friends. 馃ぃ 馃ぃ

@tagavari
Copy link
Member

tagavari commented Jul 3, 2022

Thanks for the suggestion! I'll see if I can get around to this at some point

@tagavari tagavari changed the title Emoji Add emoji picker Jul 3, 2022
@tagavari tagavari added the enhancement New feature or request label Jul 3, 2022
@Hoodgail
Copy link
Author

Hoodgail commented Jul 7, 2022

Thanks for the suggestion! I'll see if I can get around to this at some point

Np, you wounlnt need to make the component your self. Since there are many open source react versions, such as emoji-mart

@Geczy
Copy link

Geczy commented Jul 13, 2022

emoji mart is good but still doesn't support typescript, so it will not integrate with this project well

the only other option is emoji-picker-react but that one is extremely slow and bad for the site, lags everything

@tagavari
Copy link
Member

@Geczy I see that you've created a PR with emoji-picker-react, thank you for that!

For reference, most popular NPM packages have types created for them with the @types/ prefix. emoji-mart has @types/emoji-mart on NPM. I haven't tested this package though.

If emoji-picker-react doesn't perform well, then it may be worth trying with emoji-mart again

@Geczy
Copy link

Geczy commented Jul 14, 2022

yeah even with @types/emoji-mart it was still failing in several places. that type is for v3 of emoji-mart, but the latest is v5 so maybe thats the issue :( there's an open issue on emoji-mart repo to update it to v5 :/

@Geczy
Copy link

Geczy commented Jul 18, 2022

i think its better to just use the system builtin emoji picker. no web emojipicker will ever top that

To open the emoji keyboard, hold the Windows key down, and press either the period . or semicolon ; key.

Windows key + .

Alternatively,

Windows key + ;

This keyboard shortcut will open an emoji keyboard like the one shown below.

image

@Hoodgail
Copy link
Author

Hoodgail commented Jul 20, 2022

@Geczy Not everyone uses windows. Does linux & macos & chrome OS have a native emoji picker that works like that?

@Geczy
Copy link

Geczy commented Jul 20, 2022

@Geczy Not everyone uses windows. Does linux & macos & chrome OS have a native emoji picker that works like that?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Changes in consideration
Development

No branches or pull requests

3 participants