Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency warnings when building #6394

Open
gunnx opened this issue May 16, 2024 · 2 comments
Open

Circular dependency warnings when building #6394

gunnx opened this issue May 16, 2024 · 2 comments

Comments

@gunnx
Copy link

gunnx commented May 16, 2024

Provide a general summary of the issue here

When building our application we get warnings from packages used by React Aria:

🤔 Expected Behavior?

No errors during build

😯 Current Behavior

Errors shown :

Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/utils.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/queries.mjs -> node_modules/@internationalized/date/dist/conversion.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/string.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/react-aria-components/dist/Dialog.mjs -> node_modules/react-aria-components/dist/Popover.mjs -> node_modules/react-aria-components/dist/Dialog.mjs

💁 Possible Solution

Shared functions or types might require to be moved out to be imported separately or import paths changed

🔦 Context

No response

🖥️ Steps to Reproduce

Install react-aria-components 1.2.0

import { Button as AriaButton, DateInput as AriaDateInput, DatePicker as AriaDatePicker, DateSegment as AriaDateSegment, Dialog as AriaDialog, Group as AriaGroup, Popover as AriaPopover, DateValue } from 'react-aria-components';

run a build , we use rollup and errors are showing during the bundling

Version

react-aria-components@1.2.0

What browsers are you seeing the problem on?

Firefox

If other, please specify.

No response

What operating system are you using?

Mac

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@pboling
Copy link

pboling commented May 28, 2024

Using vite we get similar warnings:

[WebServer] Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs
[WebServer] Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/utils.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/queries.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/conversion.mjs
Circular dependency: node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/string.mjs -> node_modules/.pnpm/@internationalized+date@3.5.4/node_modules/@internationalized/date/dist/CalendarDate.mjs

@snowystinger
Copy link
Member

linking relevant issue from rollup rollup/rollup#1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants