-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Testing Wait for Webhook Action #4630
Comments
@rita-gorokhod @HoldYourWaffle Your input is appreciated |
If I understand correctly this'd basically be a more primitive variant of the existing "Wait for approval" piece.
Would this test URL be flow-scoped and immutable?
It's an interesting UX-design problem for sure... This avoids two manually/implicitly coupled pieces, which makes mistakes less likely, is easier to teach, handles multiple approval steps in a flow without issue and is future-proof for a potential parallelization mechanic where multiple branches could be waiting at the same time. In any case, informing/guiding the user is paramount, for example:
Curious what your thoughts are on this :) |
I dont think the url can be flow scoped, it has to be flow run scoped thats why we need two different url. Now it's also get tricker when multiple approvals or waiting if they share same link that mean the same person on the first url can trigger the flow until the end not only their specific step. This could be a security issue for approval piece. So my suggestion goes to have a testing url when the user clicks test, it shows a url and instructions. And user can use another step to generate url for the production purposes in one of the previous steps. |
Ah hang on, I was specifically referring to the URL for testing. It'd be super convenient if that one was flow-scoped and immutable, so you can test things more easily.
This wouldn't be an issue with the "control structure" approach I suggested earlier, right? Am I missing something here?
Makes sense to me :)
I'm not a fan of such a "separate step" approach, because it leaves a lot more room for error and is harder to teach. |
Describe the Bug
We need to create an action that wait for webhook, this is useful and can be used in pieces like "Wait for Approval", in order to make this happen we need good testing experience.
Suggested Testing Experience:
Testing URL:
Display Webhook URL in markdown, allowing users to copy and test to generate sample data.
Production URL:
We can't generate one on the piece settings as it should be tied to flow run, so we need to include some information about the run and we can't do that unless we know the run information.
The reason we need the run id to know which flow run to resume.
Thus, we need a way for the user to have access to this URL. One solution is to have another action that outputs a URL similar to generating an approval URL. I believe we can have a more user-friendly UI.
All suggestions are welcome.
The text was updated successfully, but these errors were encountered: