Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: customizable docset runner for Subscriptions #1293

Open
michaelcaterisano opened this issue Jan 24, 2024 · 1 comment
Open

Feature Request: customizable docset runner for Subscriptions #1293

michaelcaterisano opened this issue Jan 24, 2024 · 1 comment

Comments

@michaelcaterisano
Copy link
Contributor

michaelcaterisano commented Jan 24, 2024 •
edited

@benwilson512
I recently forked Absinthe because I needed to override the run_docset function, specifically to handle deduplication a bit differently. I ran across this PR that exposes a Behaviour that would allow me to write a custom docset runner without forking Absinthe: #1218 (comment)

Are there any objections to the direction of this PR? I'd love to see something like this merged and would be happy to help make any changes.
@michaelcaterisano
Copy link
Contributor Author

michaelcaterisano commented Feb 7, 2024 •
edited

@benwilson512 For viz, this PR would address this issue: #1295. Would appreciate your thoughts about the direction.

@michaelcaterisano michaelcaterisano mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcaterisano