Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reenabling back plain link detection (at some point) #5171

Open
7 tasks done
IgnacioHeredia opened this issue May 18, 2024 · 1 comment
Open
7 tasks done
Labels
feature This is a completely new feature for Zettlr.

Comments

@IgnacioHeredia
Copy link
Contributor

IgnacioHeredia commented May 18, 2024

Checklist

  • Zettlr does not possess this feature (if it does, but the feature doesn't work out for you, propose an enhancement instead.)
  • Zettlr's current features cannot be used to approximate this behaviour (otherwise, propose an enhancement instead.)
  • I have searched the documentation to make sure I did not overlook it.
  • I have searched both open and closed issues to see if someone has already proposed this.

Feature Proposal

Hi @nathanlesage,

As stated in the CHANGELOG of 3.1.0, I understand the reasons behind the disabling plain link detection.

[...] in the latest evolution of this parser plugin, the link detection was a bit too aggressive and interfered, e.g., with emphasis
highlighting. In this version, we have entirely removed our custom link detection and rely upon the more straight-forward way of detecting links.

In my personal case, I have too many such links to start manually enclosing old links with <>. And I prefer avoiding editing my notes via a Python+regex script, just in case 😅 .

[...] This changes brings Zettlr's link functionality much more into alignment with other editors as well, since this is the way that many other applications handle links as well.

The two other applications I use to edit markdown (VScode and micro) do indeed support plain link detection.

So I would like to leave this issue open in case in the future it could be reconsidered (due to improvements in the parser). Also to serve as reference to people looking for this feature.

If you nevertheless feel like closing it, I understand.

Thanks for your work! 🙏🏽

Example Workflow

To be able to detect a link with enclosing it in []<> or <>. Not having to enclose a link each time I copy it to my notes is quite convenient.

Caveats

The parser should be good enough to not mark incorrectly other things as links (like in #4679)

Do you wish to attempt implementing this yourself?

No

Platforms

  • Windows
  • macOS
  • Linux

Additional Information

No response

@IgnacioHeredia IgnacioHeredia added the feature This is a completely new feature for Zettlr. label May 18, 2024
@nathanlesage
Copy link
Member

I did indeed reconsider a bit, and want to reimplement one, but this time one that works pretty much in accordance with the corresponding Pandoc extension, that simply avoids edge cases and does a very stupid and simple way of doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is a completely new feature for Zettlr.
Projects
None yet
Development

No branches or pull requests

2 participants