Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade Ubuntu for Linux builds #5170

Merged
merged 4 commits into from
May 19, 2024

Conversation

IgnacioHeredia
Copy link
Contributor

Description

Downgrade Linux builds to use Ubuntu 20.04 (fixes #5137)

Changes

Changed the build Github Action (partially reverting 9e2178a). I say partially because I only downgraded the build jobs. The other ones (verify_version and prepare_release are still using Ubuntu 22.04).

Additional information

I did a test release and Zettlr seems to work fine with the changes.

Copy link

boring-cyborg bot commented May 18, 2024

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

  • Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
    way it was implemented is not immediately obvious?
  • Did you attempt to stick as much to current coding habits as possible?
    (Note that this does not apply to pieces of code where we ourselves
    obviously violated good coding practices, which unfortunately happens
    sometimes. But please indicate this in your PR so that we know what you
    rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

@nathanlesage
Copy link
Member

Looks good, thanks! I'll add to the Roadmap a reminder that we have to upgrade back to 22.04 in January 2025 before that release moves out of LTS.

@nathanlesage nathanlesage merged commit 5e0324c into Zettlr:develop May 19, 2024
1 check passed
Copy link

boring-cyborg bot commented May 19, 2024

There we go, your PR got merged! Welcome to the party! 🔥

imalexhu pushed a commit to imalexhu/Zettlr that referenced this pull request May 22, 2024
Co-authored-by: Hendrik Erz <hendrik@zettlr.com>
imalexhu pushed a commit to imalexhu/Zettlr that referenced this pull request May 22, 2024
Co-authored-by: Hendrik Erz <hendrik@zettlr.com>
imalexhu pushed a commit to imalexhu/Zettlr that referenced this pull request May 22, 2024
Co-authored-by: Hendrik Erz <hendrik@zettlr.com>
imalexhu pushed a commit to imalexhu/Zettlr that referenced this pull request May 22, 2024
Co-authored-by: Hendrik Erz <hendrik@zettlr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch error: GLIBCXX_3.4.29 not found
2 participants