Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get rid of unnecessary setup_python_defs calls #63

Open
lucidLuckylee opened this issue May 11, 2023 · 0 comments
Open

refactor: get rid of unnecessary setup_python_defs calls #63

lucidLuckylee opened this issue May 11, 2023 · 0 comments
Labels
beginner-friendly Good first issue for people wanting to contribute to this project. enhancement Enhancement of the code, not introducing new features. no-stale This is exempt from the stale bot. priority-low Nice addition, maybe... someday...

Comments

@lucidLuckylee
Copy link
Member

We sometimes call setup_python_defs in files other than the two headers_chain_proof and chain_proof main.cairo or before a test. Can confirm that by looking at the btc_api warnings when running make unit_test. The API should only be created once in each test.

Remove setup_python_defs calls from every other file and confirm that the tests and chain_proofs are still working afterwards. If every unnecessary call is removed tests should only print the Blockstream Warning at most once.

@lucidLuckylee lucidLuckylee added enhancement Enhancement of the code, not introducing new features. priority-low Nice addition, maybe... someday... no-stale This is exempt from the stale bot. beginner-friendly Good first issue for people wanting to contribute to this project. labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly Good first issue for people wanting to contribute to this project. enhancement Enhancement of the code, not introducing new features. no-stale This is exempt from the stale bot. priority-low Nice addition, maybe... someday...
Projects
None yet
Development

No branches or pull requests

1 participant