Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Search panel's misleading information on search new pattern #1677

Open
1 task done
mehlian opened this issue May 15, 2024 · 0 comments
Open
1 task done

[Bug] Search panel's misleading information on search new pattern #1677

mehlian opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mehlian
Copy link

mehlian commented May 15, 2024

Operating System

Windows

What's the issue you encountered?

When you search for items in 'Hex editor' view using 'search panel' (ctrl+f) misleading 'No more results' information may appear.

How can the issue be reproduced?

  1. open any file with unique bytes patterns
  2. open 'search panel' using ctrl+f and search for hex values that are stored in the middle of the file and press enter to highlight/select that pattern
  3. while 'search panel' is still open change searching hex values to those that appear before those in the middle of file (first we searching for hex that is only in the middle of file, then we search for hex that is only at start of file)
  4. 'search panel' informs us that there are 'No more results' but instead it should found new pattern.

ImHex Version

1.33.0

ImHex Build Type

  • Nightly or built from sources

Installation type

Portable

Additional context?

This issue occurs because on value change in 'search panel' we do not search from beginning of the file but where we last stopped.

@mehlian mehlian added the bug Something isn't working label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant