Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin.def needs cleanup to be considered source code #526

Open
Vexu opened this issue Oct 19, 2023 · 0 comments
Open

Builtin.def needs cleanup to be considered source code #526

Vexu opened this issue Oct 19, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@Vexu
Copy link
Owner

Vexu commented Oct 19, 2023

Builtins/Builtin.def is currently generated from various LLVM Builtins*.def files. To consider it source code maintained by us it needs some modifications.

Potential modifications are:

  • grouping builtins by target/kind/etc.
  • adding an include directive and splitting it into multiple files
  • adding comments about the builtins usage

The type descriptions are also subject to changes.
@Vexu Vexu added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2023
@Vexu Vexu mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vexu