Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why is Eigendamage and FPGM not docummented nor exposed in importance.py #361

Open
Hrayo712 opened this issue Mar 27, 2024 · 1 comment

Comments

@Hrayo712
Copy link

Hi @VainF ,

first of all, thanks for the great work!

Looking at importance.py I noticed that there are 2 importances which are not documented in the docs, nor exposed, that is, FPGMImportance and OBDCImportance.

I was wondering, is there a reason why ? maybe they are under development or not well tested ?

Thanks in advance for the clarification!

@VainF
Copy link
Owner

VainF commented Mar 27, 2024

Hi @Hrayo712, these two criteria were added recently by @HollyLee2000. We need more evaluation results for them.

An example can be found here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants