Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite config to use figment #272

Open
amouat opened this issue Aug 23, 2021 · 0 comments
Open

Rewrite config to use figment #272

amouat opened this issue Aug 23, 2021 · 0 comments

Comments

@amouat
Copy link
Contributor

amouat commented Aug 23, 2021

With Trow moving to use Rocket 0.5, the way configuration is handled has changed. Rocket now uses the much more flexible figment system: https://docs.rs/figment/0.10.6/figment/index.html.

We can really clean up a lot of needlessly confusing code and also support of config file by taking advantage of figment. Basically the same figment config would be passed to the Trow frontend, Rocket and the Trow backend. The Trow frontend would need to add some config for Rocket. Each step would just pull out the keys they need and ignore the rest.

As a second step it should be trivial to add support for an external YAML/json file holding config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant