Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Reorder rendering techniques/keys/props lessons #4379

Open
3 of 5 tasks
MaoShizhong opened this issue Feb 6, 2024 · 3 comments
Open
3 of 5 tasks
Labels
Status: Needs Review This issue/PR needs an initial or additional review

Comments

@MaoShizhong
Copy link
Contributor

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Feature Request: brief description of feature request format, e.g. Feature Request: Add a dark mode to the website
  • Would you like to work on this issue?

Description of the Feature Request

The current React course has the following order of lessons:

  1. Rendering techniques (lists/conditional)
  2. Keys
  3. Passing data between components

The first two lessons include code examples that demonstrate and rely on the use of keys (which in turn, benefits from the understanding of props). In each of those first two lessons, there are notes saying "don't worry about XYZ, they will be covered later", and the assigned react.dev lessons also include examples and sections on those topics which the course says to ignore for now.

Meanwhile, the props lesson and its assigned react.dev lesson do not include examples of conditional rendering, nor rendering lists and keys.

A recent issue with the current order involved the rendering techniques lesson not being 100% explicit that the react.dev rendering techniques exercises should be skipped, as they involve using keys/extracting out components with props. It only says to ignore the last section on keys. Recently, a learner had a lot of trouble with one of these exercises which was further made more difficult because I and other helpers did not realise they were attempting those exercises before learning about keys and props.

Acceptance criteria

  • Reorder the three lessons to:
    1. Passing data between components
    2. Rendering techniques
    3. Keys (I actually think introducing list rendering before keys makes more sense)
  • In the curriculum repo, amend the above lessons as necessary to accommodate for the new order (e.g. remove mentions of "don't worry about props", reference the previous props lesson if appropriate etc.)

Additional Comments

Link to reordering suggestion in the react discord channel

@MaoShizhong MaoShizhong added the Status: Needs Review This issue/PR needs an initial or additional review label Feb 6, 2024
@CouchofTomato
Copy link
Member

@TheOdinProject/react Can someone take a look please.

@ParagPalkar
Copy link

I would like to contribute !!

@MaoShizhong
Copy link
Contributor Author

MaoShizhong commented Mar 18, 2024

I'm going to leave this issue open in case any other maintainers want to share thoughts on it.

In the meantime, I'm personally leaning a little more on the "leave the order as it is" side currently as:

  • confusions caused by this haven't been too common lately - will reevaluate if needs be
  • changing the lesson order will cause confusion for some who are going through these lessons and a potentially silent order change can cause them to miss a lesson or two

So I feel for now, even though the order is a little less optimal, the current implementation may still be "good enough" to not warrant short term disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review
Projects
Status: 📋 Backlog / Ideas
Development

No branches or pull requests

3 participants