Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PendingComponent isn't shown while beforeLoad is pending on root route #1601

Closed
freshgiammi opened this issue May 16, 2024 · 0 comments · Fixed by #1611
Closed

PendingComponent isn't shown while beforeLoad is pending on root route #1601

freshgiammi opened this issue May 16, 2024 · 0 comments · Fixed by #1611

Comments

@freshgiammi
Copy link
Contributor

Describe the bug

Since 1.31.28, PendingComponent on the root route isn't shown while beforeLoad is pending. This looks like it was introduced by 854e522#diff-4cfd6abe2272d72c1dd073ec37936ad823bcd1f9418b466a9dea8b50214448f8R186.
Instead, a white page is shown as nothing gets mounted.

Your Example Website or App

https://stackblitz.com/edit/github-khgssk-d8fyff

Steps to Reproduce the Bug or Issue

  1. Open app
  2. Wait for root beforeLoad to resolve
  3. Observe that the pendingComponent is never shown

Expected behavior

PendingComponent should be shown.

Screenshots or Videos

No response

Platform

  • OS: macOS
  • Browser: Chrome
  • TSR Version: 1.32.12

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(react-router): allow root route to be wrapped in suspense freshgiammi/router
1 participant
@freshgiammi