New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent behaviour of Favourite
and Archived
tags
#138
Comments
This is the intended behavior for the "badge" icons on the entry thumbnails. The badges are shown when the respective Favorite or Archived tags are present on the entry, regardless of which field they're in. By clicking a filled-in "favorite" badge, that initiates the "unfavoriting" process that removes all instances of the favorite tag from the entry. If it only removed the favorite tag from the Meta field but the tag was still present in another field, then this would cause strange behavior: the entry's favorite icon would still be filled-in with no easy way to remove it as a favorite, and it would still show up as a favorite in searches. So while it's not the same as removing an individual tag from a specific field, the process itself is consistent within the (admittedly small) badge icon system. In other words, toggling the badges will affect the entire entry, not just a specific field inside of the entry. |
ok, but in that case I'd expect the same behaviour when favoriting the item via the badge icon, ie. the tag will be added not only in Meta Tags, but also Tags |
Here's the perspective I'm looking at it from: An entry is marked as a Favorite if it contains a Favorite tag, and isn't marked as a Favorite if it does not contain this tag. When turning that functionality into a toggle, then toggling it as a Favorite will meet the minimum requirements by adding a Favorite tag, which at the time of writing defaults to the Meta Tag group. Conversely, if you were to toggle the entry as not a Favorite, you would need to meet the requirements of making sure that the entry no longer contains a Favorite tag. Due to being able to have the same tag under multiple groups, this means that there could be multiple favorite tags that need to be removed. So functionally the Favorite toggle operates on the idea of "meet the requirements of making the entry a Favorite" and "meet the requirements of removing the entry as a Favorite", while aligning itself with how tags and field groups currently work. There are changed planned to how fields operate and are created, especially when it comes to tags, but this example should still hold true. If anything, in the future tags being in a certain "group" will have more of an hierarchical impact than just a visual one alone. |
when I click the star icon on item, it adds
Favorite
into "Meta Tags" fieldI can assign the tag "Favorite" into "Tags" field manually
I click the star icon again to remove the tag, I would assume it will remove it only from "Meta Tags", but it gets removed from "Tags" as well.
This feels inconsistent. What is the intended behaviour here?
The text was updated successfully, but these errors were encountered: