Instructor's Student Records Page: Accessibility issue for comment buttons #12664
Comments
weiquu
added
a-UIX
|
Good First Issue - Notes for Contributors Please note that we allow only one We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it. To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR. If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum. |
|
hii @weiquu I would like to work on this one and want to ask when we go to the Comment section the button for comment also has no description can I work on this one |
|
Hi @rahulpro2001, if I'm not wrong, the comment button is being picked up by the screen reader correctly. You can enable your own screen reader to check. I'm on mac, so here are the commands I use - if you're using a different OS, I'm sure you can find the instructions of how to enable their screen reader online. Regardless, do ensure that all buttons are being correctly read by the screen reader and in the right order when you eventually submit a PR (i.e. please resolve this issue fully). |
|
okk @weiquu |
|
@weiquu can we change the order of buttons or not? |
Hi @rahulpro2001, please change the order the screen reader picks up the buttons, but do not change the visual order of the buttons. |
|
okk will update you shortly |
|
@weiquu Hi! I'm a first timer and would like to contribute to this issue if possible. |
|
Hi @willzoo, sure please feel free to submit a PR for this issue |
|
Hi, can I work on this issue? |
|
Hi, is the issue still open? Can I work on it? |
|
Sure, please feel free to submit a PR |
|
Hey, i am a student and i am curious if this issue is still open? i like to work on this if it is possible. |
When using a screen reader, the comment buttons are simply read as "button", with no other information on what the button does. Here are the 2 comment buttons (edit and delete):
Let's add a description that the screen reader can pick up.
In addition, the buttons when adding/editing a comment are picked up in the wrong order by the screen reader. Here is the buttons (discard and save) for editing a comment; the same issue exists for adding a comment (cancel and save):
The screen reader first goes to Save and then Discard. Let's change the ordering so that the screen reader goes to Discard and then Save, to follow the visual order on the page
The text was updated successfully, but these errors were encountered: