Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows Server 2022 to Docker Hub image #139

Open
ldti opened this issue Aug 22, 2021 · 11 comments
Open

Add support for Windows Server 2022 to Docker Hub image #139

ldti opened this issue Aug 22, 2021 · 11 comments

Comments

@ldti
Copy link

ldti commented Aug 22, 2021

Per #138, Please update the Docker image on Hub when possible with the latest py-kms version, including Server 2022 support.

Thank you in advance.

@simonmicro
Copy link
Contributor

Okay, I plan to switch here to use GitHub Actions instead of the Docker Hub infrastructure - I found some notes here: https://blog.oddbit.com/post/2020-09-25-building-multi-architecture-im/

@SystemRage I will need some more permissions to use the Github Actions here - I kindly ask you to extend my permissions so I'm at least able to accept PRs myself for this repository (maybe even (co-)maintainer level). Feel free to PM me so we can chat about that 😃

@thespad
Copy link

thespad commented Sep 1, 2021

If it helps anyone I've done some builds of the minimal image based on this change #138 (comment) and tested that it works with Server 2022 - though I haven't properly tested the ARM builds.

docker pull ghcr.io/thespad/py-kms:latest

Sources etc: https://github.com/TheSpad/docker-py-kms

@simonmicro
Copy link
Contributor

@thespad Thanks for your work, I'll try to use GA for all different architectures - should be easy enough :P
See my other comment until I'll do this on my own.

@simonmicro
Copy link
Contributor

@thespad Thanks for your files (https://github.com/TheSpad/docker-py-kms) that I've used for inspiration - the fork (https://github.com/Py-KMS-Organization/py-kms) has now full build support for even more architectures, docker hub updates and GitHub Container Repository Integration. I hope all works now - could someone validate that?

@dudefoxlive
Copy link

@thespad Thanks for your files (https://github.com/TheSpad/docker-py-kms) that I've used for inspiration - the fork (https://github.com/Py-KMS-Organization/py-kms) has now full build support for even more architectures, docker hub updates and GitHub Container Repository Integration. I hope all works now - could someone validate that?

Will the python files also get updated to support server 2022 along with the docker image at some point in your fork? I don't want to use docker if I don't have to since I am running mine in a Proxmox LXC container.

@simonmicro
Copy link
Contributor

According to the last comment on #138 it already works?! But also I've noted the wiki was not up-to-date, therefore I added the keys for 2022 there.

@thespad
Copy link

thespad commented Sep 13, 2021

According to the last comment on #138 it already works?! But also I've noted the wiki was not up-to-date, therefore I added the keys for 2022 there.

I don't believe the fix was ever committed. When I did my builds I had to inject my own version of the file with the modifications made.

@simonmicro
Copy link
Contributor

Oh, to get that straight: All needed for the 2022 Server to work is just that one line inside 164 at ./py-kms/pykms_Base.py?

@simonmicro
Copy link
Contributor

simonmicro commented Sep 13, 2021

And it does not break anything else? In that case I'll accept any PR or add it myself - but only if anyone could confirm that for me (I do not want to break everything 😁 ).

@thespad
Copy link

thespad commented Sep 13, 2021

I can't say 100% it won't break anything else because I only tested with Server 2022 but it worked fine for me https://github.com/TheSpad/docker-py-kms/blob/main/pykms_Base.py#L164

@simonmicro
Copy link
Contributor

Okay, fix is added and pushed - let's hope for the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants