Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong highligting [observation lists] #3746

Open
axd1967 opened this issue May 18, 2024 · 2 comments
Open

wrong highligting [observation lists] #3746

axd1967 opened this issue May 18, 2024 · 2 comments
Labels
opinion OP thinks something should behave differently

Comments

@axd1967
Copy link
Contributor

axd1967 commented May 18, 2024

Expected Behaviour

'Highlight all' should take setting of coordinates into account. This checkbox does not exist yet.

When this checkbox is cleared, actual positions should be highlighted. When this checkbox is set, highlighting can show the position as stored in the obs list.

Additionally, toggling the coordinates checkbox should re-run the highlighting routine (toggling between current and stored coordinates, but only if the information is stored in the obs list).

image

This is similar to double-clicking from within an obs list line, where the behaviour depends on whether date (set->jump to date), location (set->jump to location), FOV, etc are selected.

Actual Behaviour

Highlighted coordinates do not correspond to actual coordinates
image

Steps to reproduce

  1. F3/select a comet (anything that moves significantly)
  2. edit obs list
  3. enable coordinates and date
  4. add object
  5. save list
  6. highlight all
  7. observe that the selected object is highlighted
  8. advance date/time sufficiently so that the selected object is away from its current coordinates
  9. highlight all

BUG: the coordinates as stored in step 4 are highlighted, rather than the current coordinates of the object
This makes the highlight feature less interesting, as the intention is to highlight the object, not the coordinates it was at some point in time (unless the new checkbox "coordinates" is set).

Workaround

Store the same object without coordinates.

System

  • Stellarium 24.4+
    Version 24.4.8-0de39da [master]
    Based on Qt 5.12.8
  • Operating systemOperating System: Kubuntu 20.04
    KDE Plasma Version: 5.18.8
    KDE Frameworks Version: 5.68.0
    Qt Version: 5.12.8
    Kernel Version: 5.4.0-181-generic
    OS Type: 64-bit
    Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz
    Memory: 15.3 GiB of RAM
@alex-w
Copy link
Member

alex-w commented May 18, 2024

Highlight should work for actual positions

@alex-w alex-w added the opinion OP thinks something should behave differently label May 18, 2024
@alex-w alex-w added this to Needs triage in Observing Lists via automation May 18, 2024
@gzotti
Copy link
Member

gzotti commented May 18, 2024

This may have been the reason to always store coordinates (see OP's #3694): so that we are able to show such highlights. Maybe the highlight labels should include the stored date in case of SSOs where you may have multiple entries. To highlight/find any object at some arbitrary current date, just use the Search dialog (F3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion OP thinks something should behave differently
Projects
Observing Lists
  
Needs triage
Development

No branches or pull requests

3 participants