Invalid update information in AppImage

[probonopd]

Expected Behaviour

The Stellarium AppImage either contains valid or no update information

Actual Behaviour

The Stellarium AppImage contains defective (invalid) update information

Steps to reproduce

The Stellarium AppImage contains the string "None" as update information. The string "None" is not valid update information. Hence, the AppImage is not a valid AppImage.

@probonopd ➜ /workspaces/go-appimage (master) $ objdump -x ./stellarium-24.1-qt5-x86_64.AppImage | grep upd
 27 .upd_info     00000400  0000000000000000  0000000000000000  0002c38f  2**0
@probonopd ➜ /workspaces/go-appimage (master) $ dd if=./stellarium-24.1-qt5-x86_64.AppImage skip=181135 bs=1 count=1024 | xxd
00000000: 4e6f 6e65 0000 0000 0000 0000 0000 0000  None............

The "None" should not be there.

Most likely it is caused by

• stellarium/util/appimage/stellarium-appimage-qt5.yml

  Line 85 in 7643434

  update-information: None

• stellarium/util/appimage/stellarium-appimage-qt6.yml

  Line 96 in 7643434

  sign-key: None

System

• Stellarium version: stellarium-24.1-qt5-x86_64.AppImage
• Operating system: Linux (any)

References

• [Question] What to say to app dev when "is not a proper AppImage", "too short" ? probonopd/go-appimage#276
• https://github.com/AppImage/AppImageSpec/blob/master/draft.md#update-information

[alex-w]

The Stellarium AppImage contains the string "None" as update information.

yes, as it described in documentation and in examples, so, why isn’t valid now?

[probonopd]

Well, because the string "None" is not valid according to the spec.

as it described in documentation and in examples

Can you point me toward that please? You are using appimage-builder, correct? https://appimage-builder.readthedocs.io/en/latest/advanced/updates.html does not mention "None".

cc @azubieta

[alex-w]

Hello @probonopd!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot