Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monster string provider: IndexError: list index out of range #662

Open
sentry-io bot opened this issue Nov 20, 2023 · 1 comment
Open

monster string provider: IndexError: list index out of range #662

sentry-io bot opened this issue Nov 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Nov 20, 2023

Sentry Issue: SKYTEMPLE-1CZ

IndexError: list index out of range
  File "controller\main.py", line 343, in on_file_opened
  File "module\monster\module.py", line 112, in load_tree_items
  File "core\string_provider.py", line 105, in get_value
@theCapypara theCapypara added the bug Something isn't working label Nov 20, 2023
@theCapypara theCapypara added this to To do in Core: All open issues via automation Nov 20, 2023
@End45
Copy link
Member

End45 commented Apr 30, 2024

Some more details from someone who recently experienced this issue: ExpandPokeList is applied.

Seems like SkyTemple tries to pull the pokémon name from the string list, and the error shows up when the list is overflown.
Responsible line of code:

return model.strings[self.get_index(string_type, index)]

I don't know how pokémon names are handled with ExpandPokeList, but it's unlikely they are just pulled from the string list like this. Why does SkyTemple try to read them from the string list when the patch is applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants