AssertionError: Title length must be less than 256 characters (Icon Banner)

[sentry-io]

Sentry Issue: SKYTEMPLE-1VY

AssertionError: Title length must be less than 256 characters
  File "core\rom_project.py", line 420, in _save_impl
  File "skytemple_files\hardcoded\icon_banner.py", line 131, in save_to_rom
  File "skytemple_files\hardcoded\icon_banner.py", line 33, in _utf16_encode_fixed

[theCapypara]

This is a bit tricky, the encoding happens at save currently.

Since it's UTF-16 we should probably limit the max number of character to 128 in the text view, but there's no easy built-in way to do this.

Also @tech-ticks since you wrote this error: If it's UTF-16 isn't the error message actually wrong, shouldn't it say 128 characters?

[tech-ticks]

Yeah, it should say 256 bytes instead of characters. Since a UTF-16 character is either 2 or 4 bytes, limiting the number of characters to 128 isn't correct either, technically.

[theCapypara]

Oh right, forgot about 4 byte characters. Well it's probably good enough for practical purposes.