Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOT operators to survey URL targeting rules #22281

Open
dmarticus opened this issue May 14, 2024 · 4 comments
Open

Add NOT operators to survey URL targeting rules #22281

dmarticus opened this issue May 14, 2024 · 4 comments

Comments

@dmarticus
Copy link
Contributor

dmarticus commented May 14, 2024

Feature request

Is your feature request related to a problem?

Not really, just feels like an easy feature to implement that we don't have yet.

image

Describe the solution you'd like

Feels like all of these matchers should have an equivalent NOT matcher. Could be useful for users to filter out fields containing or equal to thinks without writing a RegEx rule.

Obviously, this can be worked around, but it seems like a quality-of-life improvement.

@shawnlikescode
Copy link

Hi! Can I try to implement this one?

Are you thinking just doesn't contain and doesn't equal or should there also be doesn't match regex?

@dmarticus
Copy link
Contributor Author

Hi @shawnlikescode, thanks for your interest! I was thinking that we'd implement the following matchers:

  • doesn't contain
  • doesn't equal
  • doesn't match regex

like we do with the User Property targeting

image

Happy coding, and I look forward to seeing what you come up with :)

@shawnlikescode
Copy link

Hey, @dmarticus! Working on this now. I think I understand what's required, but I just want to verify before I get all gung ho and dive in.

From what I gather, this feature will involve two PRs:

  1. In the Posthog repo, I'll add the NOT operator options for the selection input on URL targeting.
  2. In the posthog-js repo, I'll update the validations in src/posthog-survey.ts.

Does this sound correct? Thanks!

@neilkakkar
Copy link
Collaborator

That sounds about right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants