Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language for Org Admins when they're changing the team lead #9732

Open
charlesmathias opened this issue May 7, 2024 · 1 comment 路 Fixed by #9767
Open

Update language for Org Admins when they're changing the team lead #9732

charlesmathias opened this issue May 7, 2024 · 1 comment 路 Fixed by #9767
Assignees
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@charlesmathias
Copy link

Slack link with screenshot 馃敀

When an Org Admin edits the Team Lead of a team, they see a message that only makes sense to Team Leads who are giving up their permissions to edit team membership.

I'd suggest "Are you sure? User X will be removed as the team leader and User Y will be promoted. User X will no longer be able to change team membership." The title and CTA for this message can remain the same.

@jordanh jordanh added the p2 Needs to be addressed on a reasonable timescale label May 7, 2024
@nickoferrall nickoferrall self-assigned this May 9, 2024
@charlesmathias
Copy link
Author

@nickoferrall I think this isn't quite right... See below a gif from the perspective of an Org Admin when they're making themselves a Team lead.

User X: Current Team lead
User Y: New Team lead

Right now, it reads:
"Are you sure? User X will be removed as the team leader and User Y will be promoted. User Y will no longer be able to change team membership."

It should be User X in the last sentence unless User X is an Org Admin. If they are an Org Admin, I propose removing the last sentence.

2024-05-31 12 03 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: Done
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants