Create2 doesn't bubble up returndata on revert

[frangio]

When a contract deployment fails in Create2, returndata is ignored even though it may contain a revert reason that should probably be bubbled up like the Address library does for calls. I haven't checked if Solidity does this for native contract creation.

openzeppelin-contracts/contracts/utils/Create2.sol

Line 49 in 255e27e

revert Errors.FailedDeployment();

[ernestognw]

Seems like it does bubble up the revert reason. I tested the following in Remix:

pragma solidity ^0.8.24;

contract A {
    constructor() {
        revert("Some message");
    }
}

contract Test {
    constructor() {
        new A{salt:keccak256("some salt")}();
    }
}

The result is that Some message is shown in the console.

Reason provided by the contract: "Some message".

Although it seems to be the default behavior in Solidity, this is one of those cases where bubbling up the revert reason adds an extra instruction that nobody asked for 🤔.

Although factories should rely mostly on Clones for deterministic deployments instead of Create2, I wonder if there's a use case we this extra instruction would represent significative costs.