Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with models not using position_ids #270

Open
kfertakis opened this issue Apr 15, 2024 · 1 comment
Open

Issue with models not using position_ids #270

kfertakis opened this issue Apr 15, 2024 · 1 comment

Comments

@kfertakis
Copy link
Contributor

I think this issue relates to #217 and #218. Some models, for example facebook/opt-1.3b, don't accept position_ids as an argument and current implementation using it (used here, here and here) leads to the following error. Is there a way this argument is conditional to whether the model used supports it as input?

TypeError: OPTModel.forward() got an unexpected keyword argument 'position_ids'

Thank you,

@hijkzzz
Copy link
Collaborator

hijkzzz commented Apr 16, 2024

Interesting issue. Let me figure out how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants