Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test: Agent doesn't think it finishes the task yet test still passes #1805

Open
li-boxuan opened this issue May 15, 2024 · 0 comments
Open

Integration test: Agent doesn't think it finishes the task yet test still passes #1805

li-boxuan opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working severity:low Minor issues, code cleanup, etc test Test cases and testing framework changes

Comments

@li-boxuan
Copy link
Collaborator

li-boxuan commented May 15, 2024 •
edited 

          @xingyaoww I think this is a regression by https://github.com/OpenDevin/OpenDevin/pull/1755. Clearly PlannerAgent doesn't think it has finished the task yet the test still pass, indicating it is not sufficient to just verify `AgentState.STOPPED`.

Maybe it "stopped" because it used up all of the iterations? Maybe we should set the state to ERROR?

Originally posted by @li-boxuan in #1777 (comment)
@li-boxuan li-boxuan mentioned this issue May 15, 2024
Merged
@li-boxuan li-boxuan added bug Something isn't working test Test cases and testing framework changes severity:low Minor issues, code cleanup, etc labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working severity:low Minor issues, code cleanup, etc test Test cases and testing framework changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@li-boxuan