Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pika 添加命中率指标 #2423

Open
huxiaozhe opened this issue Feb 27, 2024 · 4 comments
Open

pika 添加命中率指标 #2423

huxiaozhe opened this issue Feb 27, 2024 · 4 comments
Assignees
Labels
3.5.3 ✏️ Feature New feature or request

Comments

@huxiaozhe
Copy link

Which PikiwiDB functionalities are relevant/related to the feature request?

No response

Description

keyspace_hits:711364981104
keyspace_misses:10870411985
与 redis 的命中 miss指标保持一致,方便业务侧更加直观的看到自己的命中率。

Proposed solution

pika 中可以使用原子操作进行计算

Alternatives considered

@huxiaozhe huxiaozhe added the ✏️ Feature New feature or request label Feb 27, 2024
@luky116
Copy link
Collaborator

luky116 commented Mar 22, 2024

柏韬处理

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Bertolt Processing

@chenbt-hz
Copy link
Collaborator

@luky116 确认下。这个issue需要添加的是:查询命令是否成功查找到key,与pika cache的统计无关。
即,执行查询命令当key能正确返回时keyspace_hits加一,否则keyspace_misses加一。
参考 https://redis.io/commands/info/

@chenbt-hz chenbt-hz self-assigned this Mar 25, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@luky116 Confirm. What needs to be added to this issue is: whether the query command successfully finds the key has nothing to do with the statistics of pika cache.
That is, when the query command is executed and the key can be returned correctly, keyspace_hits is increased by one, otherwise keyspace_misses is increased by one.
Reference https://redis.io/commands/info/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 ✏️ Feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants