Flaky Test: "Send ETH from inside MetaMask finds the transaction in the transactions list when sending to a Multisig Address"? #24574
Assignees
Labels
flaky tests
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
release-11.18.0
Issue or pull request that will be included in release 11.18.0
team-extension-platform
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
FindingsThis specific failure is due to a race condition where the balance for the account is not loaded and we try to proceed with a transaction (this causes the gasLimit be set to 0 --> this seems a separate bug). Other FindingsCannot proceed with the txWhenever I am on a regular build, I see that the gas is set to 0 and cannot proceed with the transaction.
cannot-proceed-send-contract.mp4This is similar to what we see in the test failure artifacts where we cannot proceed with the last Confirm screen in this case, and gas fee is set to 0.
Unable to Determine Contract StandardWhenever I am on a Multichain Build, if I try to Send ETH to a contract, I get the error unable-to-determine-contract-standard.mp4Contract InteractionWhenever we are sending ETH to a contract address, the Confirmations page displays it as a Contract Interaction. Is this expected?
|
7 tasks
seaona
added a commit
that referenced
this issue
May 21, 2024
…tion` (#24639) ## **Description** The problem with this flaky test is that in some occurrences we are proceeding to the last Confirmation screen without the balance being loaded (race condition). This can be observed at second 4 from this video. This test fails every time this condition is met (very often in Mutlichain build, possibly due to shorter flow of UI?) The fix is simply waiting for the balance to be loaded before proceeding with the actions. However, I think we should also revise the application behaviour, as it does not seem correct that: - whenever we proceed to the last screen without the balance being loaded, the gas is set to 0 (specifically the gas limit) - then, no matter how long we wait, the gas cannot be recovered from this and we are stucked in the confirmation screen (Confirm is disabled) --> this happens despite the balance being then loaded and also getting numerous successful responses from the gas API I'll open separate tickets for that Example of failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81147/workflows/ec5f9950-23fa-4f6f-b248-9f894813e75d/jobs/2874889/tests https://github.com/MetaMask/metamask-extension/assets/54408225/93b9bd5d-a9d2-4898-b743-8a59eed0eea2 [](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1) ## **Related issues** Fixes: #24574 ## **Manual testing steps** 1. Check ci jobs 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/transaction/send-eth.spec.js --browser=chrome --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** In the test failing artifacts we can see how we cannot proceed with the transaction as the Confirm button is disabled. However the problem is that the gas is set to 0 and never recovered, but the real root cause comes from proceeding with the previous screen without the balance loaded.  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.18.0
56 tasks
danjm
pushed a commit
that referenced
this issue
May 31, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1){kind=link}
…tion` (#24639) ## **Description** The problem with this flaky test is that in some occurrences we are proceeding to the last Confirmation screen without the balance being loaded (race condition). This can be observed at second 4 from this video. This test fails every time this condition is met (very often in Mutlichain build, possibly due to shorter flow of UI?) The fix is simply waiting for the balance to be loaded before proceeding with the actions. However, I think we should also revise the application behaviour, as it does not seem correct that: - whenever we proceed to the last screen without the balance being loaded, the gas is set to 0 (specifically the gas limit) - then, no matter how long we wait, the gas cannot be recovered from this and we are stucked in the confirmation screen (Confirm is disabled) --> this happens despite the balance being then loaded and also getting numerous successful responses from the gas API I'll open separate tickets for that Example of failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81147/workflows/ec5f9950-23fa-4f6f-b248-9f894813e75d/jobs/2874889/tests https://github.com/MetaMask/metamask-extension/assets/54408225/93b9bd5d-a9d2-4898-b743-8a59eed0eea2 [](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1) ## **Related issues** Fixes: #24574 ## **Manual testing steps** 1. Check ci jobs 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/transaction/send-eth.spec.js --browser=chrome --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** In the test failing artifacts we can see how we cannot proceed with the transaction as the Confirm button is disabled. However the problem is that the gas is set to 0 and never recovered, but the real root cause comes from proceeding with the previous screen without the balance loaded.  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
pushed a commit
that referenced
this issue
May 31, 2024
…tion` (#24639) ## **Description** The problem with this flaky test is that in some occurrences we are proceeding to the last Confirmation screen without the balance being loaded (race condition). This can be observed at second 4 from this video. This test fails every time this condition is met (very often in Mutlichain build, possibly due to shorter flow of UI?) The fix is simply waiting for the balance to be loaded before proceeding with the actions. However, I think we should also revise the application behaviour, as it does not seem correct that: - whenever we proceed to the last screen without the balance being loaded, the gas is set to 0 (specifically the gas limit) - then, no matter how long we wait, the gas cannot be recovered from this and we are stucked in the confirmation screen (Confirm is disabled) --> this happens despite the balance being then loaded and also getting numerous successful responses from the gas API I'll open separate tickets for that Example of failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81147/workflows/ec5f9950-23fa-4f6f-b248-9f894813e75d/jobs/2874889/tests https://github.com/MetaMask/metamask-extension/assets/54408225/93b9bd5d-a9d2-4898-b743-8a59eed0eea2 [](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1) ## **Related issues** Fixes: #24574 ## **Manual testing steps** 1. Check ci jobs 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/transaction/send-eth.spec.js --browser=chrome --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** In the test failing artifacts we can see how we cannot proceed with the transaction as the Confirm button is disabled. However the problem is that the gas is set to 0 and never recovered, but the real root cause comes from proceeding with the previous screen without the balance loaded.  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
pushed a commit
that referenced
this issue
May 31, 2024
…tion` (#24639) ## **Description** The problem with this flaky test is that in some occurrences we are proceeding to the last Confirmation screen without the balance being loaded (race condition). This can be observed at second 4 from this video. This test fails every time this condition is met (very often in Mutlichain build, possibly due to shorter flow of UI?) The fix is simply waiting for the balance to be loaded before proceeding with the actions. However, I think we should also revise the application behaviour, as it does not seem correct that: - whenever we proceed to the last screen without the balance being loaded, the gas is set to 0 (specifically the gas limit) - then, no matter how long we wait, the gas cannot be recovered from this and we are stucked in the confirmation screen (Confirm is disabled) --> this happens despite the balance being then loaded and also getting numerous successful responses from the gas API I'll open separate tickets for that Example of failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81147/workflows/ec5f9950-23fa-4f6f-b248-9f894813e75d/jobs/2874889/tests https://github.com/MetaMask/metamask-extension/assets/54408225/93b9bd5d-a9d2-4898-b743-8a59eed0eea2 [](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1) ## **Related issues** Fixes: #24574 ## **Manual testing steps** 1. Check ci jobs 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/transaction/send-eth.spec.js --browser=chrome --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** In the test failing artifacts we can see how we cannot proceed with the transaction as the Confirm button is disabled. However the problem is that the gas is set to 0 and never recovered, but the real root cause comes from proceeding with the previous screen without the balance loaded.  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
pushed a commit
that referenced
this issue
May 31, 2024
…tion` (#24639) ## **Description** The problem with this flaky test is that in some occurrences we are proceeding to the last Confirmation screen without the balance being loaded (race condition). This can be observed at second 4 from this video. This test fails every time this condition is met (very often in Mutlichain build, possibly due to shorter flow of UI?) The fix is simply waiting for the balance to be loaded before proceeding with the actions. However, I think we should also revise the application behaviour, as it does not seem correct that: - whenever we proceed to the last screen without the balance being loaded, the gas is set to 0 (specifically the gas limit) - then, no matter how long we wait, the gas cannot be recovered from this and we are stucked in the confirmation screen (Confirm is disabled) --> this happens despite the balance being then loaded and also getting numerous successful responses from the gas API I'll open separate tickets for that Example of failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/81147/workflows/ec5f9950-23fa-4f6f-b248-9f894813e75d/jobs/2874889/tests https://github.com/MetaMask/metamask-extension/assets/54408225/93b9bd5d-a9d2-4898-b743-8a59eed0eea2 [](https://codespaces.new/MetaMask/metamask-extension/pull/24639?quickstart=1) ## **Related issues** Fixes: #24574 ## **Manual testing steps** 1. Check ci jobs 2. Run test multiple times locally `yarn test:e2e:single test/e2e/tests/transaction/send-eth.spec.js --browser=chrome --leave-running=true --retry-until-failure --retries=15` ## **Screenshots/Recordings** In the test failing artifacts we can see how we cannot proceed with the transaction as the Confirm button is disabled. However the problem is that the gas is set to 0 and never recovered, but the real root cause comes from proceeding with the previous screen without the balance loaded.  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Failure
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/80402/workflows/41cbd58d-f379-4fb3-98a3-56004e8b8872/jobs/2836380/tests
Screenrecording
gas0.mp4
Gas Limit is set to 0 and there is no way the gas values are updated, even after subsequent successful gas api calls (mocked responses)
The text was updated successfully, but these errors were encountered: