Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FadeOut on DiGraph does not work smoothly #3749

Open
uwezi opened this issue May 5, 2024 · 1 comment · May be fixed by #3786
Open

FadeOut on DiGraph does not work smoothly #3749

uwezi opened this issue May 5, 2024 · 1 comment · May be fixed by #3786

Comments

@uwezi
Copy link
Contributor

uwezi commented May 5, 2024

Description of bug / unexpected behavior

ManimCE v0.18.1

Using self.play(Fadeout()) on a DiGraph() object does not correctly fade out the edges, only the nodes and arrow tips. Removing the individual subobjects works.

Link to the Discord discussion

Expected behavior

All elements of a DiGraph() should fade smoothly out.

How to reproduce the issue

Code for reproducing the problem
class IntroductionToGraphs(Scene):
    def construct(self):
        vertexs = [num for num in range(1,7)]
        arestes = [(1,2), (3,1), (1,5), (1,6), (5,1), (5,6), (3,4)]
        layout = "circular"

        graf_arestes1 = Graph(vertexs, arestes, labels = True, layout = layout)
        graf_arestes2 = DiGraph(vertexs, arestes, labels = True, layout = layout)
        graf_arestes3 = graf_arestes2.copy()

        graf_arestes1.scale_to_fit_width(14/3).to_edge(LEFT, buff=0)
        graf_arestes2.scale_to_fit_width(14/3)
        graf_arestes3.scale_to_fit_width(14/3).to_edge(RIGHT, buff=0)

        self.play(
            Create(graf_arestes1),
            Create(graf_arestes2),
            Create(graf_arestes3),
        )
        self.wait()
        self.play(
            FadeOut(graf_arestes1),
            FadeOut(graf_arestes2),
            FadeOut(*[obj for obj in graf_arestes3])
        )

Additional media files

Images/GIFs
IntroductionToGraphs.mp4

System specifications

System Details irrelevant - the problem occurs on both Windows 10 and Manimator
@Nikhil-42
Copy link
Contributor

This is an issue with the edge updater in the DiGraph. I'll take a look at it.

@Nikhil-42 Nikhil-42 linked a pull request May 29, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants