-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put_start_and_end_on does not work with Arrow3D #3655
Comments
I will look into this. |
good knew |
Care to elaborate? |
Tommorow I will create a PR. The problem was in scaling. I had to add a get_start and get_end methods for cone and arrow3d classes. |
SirJamesClarkMaxwell
added a commit
to SirJamesClarkMaxwell/manim
that referenced
this issue
Apr 16, 2024
3 tasks
Cool thank you! I tried out the PR and it works beautifully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of bug / unexpected behavior
In 2D, put_start_and_end_on can be used to animate the tip of an arrow. In 3D the size/volume of the arrow appears to increase without bound, and also rotates much more than expected.
Expected behavior
The same behaviour as 2D but in 3D for an Arrow3D.
How to reproduce the issue
Code for reproducing the problem
Additional media files
Images/GIFs
ArrowAnimation.mp4
Working 2D Version
Code for reproducing the problem
Additional media files
Images/GIFs
ArrowAnimation.mp4
System specifications
System Details
python/py/python3 --version
):pip list
):FFMPEG
Output of
ffmpeg -version
:Additional comments
Even in 2D the put_start_and_end_on() method seems to use the line/vector (and ignores the triangle/cone) for the end point, whereas when initializing the Arrow class the end point does represent the tip of the triangle/cone.
The text was updated successfully, but these errors were encountered: