Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting back to CI #3622

Open
Viicos opened this issue Feb 16, 2024 · 2 comments
Open

Add linting back to CI #3622

Viicos opened this issue Feb 16, 2024 · 2 comments
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Milestone

Comments

@Viicos
Copy link
Contributor

Viicos commented Feb 16, 2024

Following #3620, would be great to enforce linting on CI.

I propose using Ruff instead of flake8, it would avoid having to install a bunch of plugins and pyproject.toml configuration is supported.

Format could be included as well if the diff isn't to big.

@Viicos Viicos added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Feb 16, 2024
@behackl
Copy link
Member

behackl commented Apr 20, 2024

I like the idea and have heard many good things about ruff. It would be nice to see a branch with this!

@JasonGrace2282 JasonGrace2282 linked a pull request May 21, 2024 that will close this issue
2 tasks
@JasonGrace2282 JasonGrace2282 added this to the v0.19.0 milestone May 21, 2024
@JasonGrace2282
Copy link
Contributor

Formatting

Linting

  • flake8-builtins
  • flake8-bugbear
  • flake8-comprehensions
  • pycodestyle
  • pyflakes
  • isort ( Add Ruff Lint #3780 )
  • pylint
  • flake8-pytest-style
  • pygrep hooks
  • ruff lint rules
  • flake8-simplify
  • pyupgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants