Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage COM Port number greater than COM9 #467

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Manage COM Port number greater than COM9 #467

merged 1 commit into from
Jan 29, 2024

Conversation

BHAY-3DiTex
Copy link

@BHAY-3DiTex BHAY-3DiTex commented Jan 23, 2024 •
edited by nicolas-rabault

PR Description section

Add \\.\ to portname for serial_network on windows.

Description and dependencies

Modify portname before calling CreateFile function in serial_network_hal.c file

Changes

  • Bug fix (non-breaking change which fixes an issue)

Before it was impossible to Init the serial network with COM Port number greater than 9

Related issue(s)

Connection on serial port COM11 at 1000000 baud
CreateFile failed with error 2.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault linked an issue Jan 23, 2024 that may be closed by this pull request
[BUG] serial_network doesn't support port name greater than COM9 #468
Open
nicolas-rabault
nicolas-rabault approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thank you!

@nicolas-rabault nicolas-rabault requested review from nicolas-rabault and Simonbdy and removed request for nicolas-rabault and Simonbdy January 23, 2024 17:18
@BHAY-3DiTex @nicolas-rabault
Add \\\\.\\ to portname for serial_network on windows
7e5d4b4 
To Manage COM Port number greater than COM9.
@nicolas-rabault nicolas-rabault requested review from JeromeGalan and removed request for JeromeGalan January 26, 2024 09:48
@nicolas-rabault nicolas-rabault merged commit b37535c into Luos-io:rc_3.1.0 Jan 29, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] serial_network doesn't support port name greater than COM9
2 participants
@BHAY-3DiTex @nicolas-rabault