Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests/system_test #959

Open
tomadamatkinson opened this issue Mar 1, 2024 · 2 comments · May be fixed by #1057
Open

Remove tests/system_test #959

tomadamatkinson opened this issue Mar 1, 2024 · 2 comments · May be fixed by #1057
Labels
build This is relevant to the build system

Comments

@tomadamatkinson
Copy link
Collaborator

The system tests are rarely used and do not really test anything useful to the samples. The closest feature we have to a full system test is vulkan_samples batch mode.

Framework V2 intends to encourage the addition of unit tests. Vulkan framework unit tests can be added and ran locally in the future.

Due to the system tests not being used and likely future implementations of a system test will be built on top of batch mode or as units should we remove this folder?

@SaschaWillems
Copy link
Collaborator

I'm fine with removing it. I guess that would also remove the CI steps, thus resulting in faster CI builds?

@SaschaWillems SaschaWillems added the build This is relevant to the build system label May 20, 2024
@tomadamatkinson
Copy link
Collaborator Author

Doesn't impact our current CI as these tests are not used in practice. It will simplify some of the projects code though so i think it is still worth it

@tomadamatkinson tomadamatkinson linked a pull request May 29, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This is relevant to the build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants