Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dates.value(::Date) #54510

Open
jariji opened this issue May 17, 2024 · 1 comment
Open

Remove Dates.value(::Date) #54510

jariji opened this issue May 17, 2024 · 1 comment
Labels
domain:dates Dates, times, and the Dates stdlib module

Comments

@jariji
Copy link
Contributor

jariji commented May 17, 2024

The value(::Date) method is not documented, it's not generic with the documented method, and I don't think we need it.

The documented method is

help?> Dates.value
  Dates.value(x::Period) -> Int64


  For a given period, return the value associated with that period. For example, value(Millisecond(10))
  returns 10 as an integer.

Method to be removed:

julia> Dates.value(Date(2000))
730120
@Seelengrab Seelengrab added the domain:dates Dates, times, and the Dates stdlib module label May 18, 2024
@quinnj
Copy link
Member

quinnj commented May 21, 2024

I think I'd be fine removing it, except I worry it would actually be fairly breaking for cases where people are using it. It unfortunately is one of those not-really-documented but some people are probably using/relying on it kind of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dates Dates, times, and the Dates stdlib module
Projects
None yet
Development

No branches or pull requests

3 participants