Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DATE PROBLEM #3145

Closed
1 task done
hkjansonchan opened this issue Apr 17, 2024 · 7 comments
Closed
1 task done

[BUG] DATE PROBLEM #3145

hkjansonchan opened this issue Apr 17, 2024 · 7 comments
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working help wanted Help us! Appreciated P0 Critical and urgent

Comments

@hkjansonchan
Copy link

Please confirm the following

Describe the bug

I just input the date & time eg 18 May 7.00am
But after I confirmed the date become 17 May and I press in it, It was 18 May 7.00am
That's weird

To Reproduce

Expected behavior

No response

Screenshots

No response

App version

4.6.3(163) from Play Store

Smartphone

Samsung Galaxy A54

Additional context

No response

@hkjansonchan hkjansonchan added the bug Something isn't working label Apr 17, 2024
@ivywallet
Copy link

Thank you @hkjansonchan for raising Issue #3145! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV added help wanted Help us! Appreciated approved Approved by the Ivy Wallet team. Ready for dev P0 Critical and urgent labels Apr 18, 2024
@sufyan-siddiqui
Copy link

@hkjansonchan can you please add more details/screenshots and the steps to reproduce the issue.

This is how I tried to reproduce it. It is working as expected.

issue_3145_not_repr.mp4

@ILIYANGERMANOV
Copy link
Collaborator

It's a timezone issue. Set your device to GMT+8 or some big difference from UTC and it'll break.

We need to work everywhere with Instant (UTC) and convert to LocalDateTime only in the UI layer when we format Instant -> String.

@palapapa
Copy link

Same problem. The transaction history screen seems to be using the GMT+0 timezone no matter what.

@rishi2062
Copy link
Contributor

I'm on it

@ivywallet
Copy link

Thank you for your interest @rishi2062! 🎉
Issue #3145 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

rishi2062 added a commit to rishi2062/ivy-wallet that referenced this issue May 26, 2024
ILIYANGERMANOV pushed a commit that referenced this issue May 27, 2024
@rishi2062
Copy link
Contributor

@ILIYANGERMANOV is this issue still open after my merge
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working help wanted Help us! Appreciated P0 Critical and urgent
Projects
None yet
Development

No branches or pull requests

6 participants