Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential boundary error in utils.py #562

Open
dongyang2011 opened this issue Apr 10, 2024 · 1 comment
Open

Potential boundary error in utils.py #562

dongyang2011 opened this issue Apr 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dongyang2011
Copy link

Hi there, in the file utils.py, there might be an error involving accessing beyond the boundary on line 208 for the operation cur_inputs_embeds_no_im[i], when the IMAGE_TOKEN_INDEX is located at the end of the input_ids. Please consider to solve it.

@LZHgrla
Copy link
Collaborator

LZHgrla commented Apr 11, 2024

The possibility indeed exists (although image tokens typically do not appear in the last one input_id, due to the prompt template).

Thank you for your feedback!

@LZHgrla LZHgrla added the bug Something isn't working label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants