Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] schedulder -> scheduler #49

Open
Spico197 opened this issue Feb 20, 2024 · 1 comment
Open

[Typo] schedulder -> scheduler #49

Spico197 opened this issue Feb 20, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@Spico197
Copy link

Describe the question.

A typo is found when loading and saving scheduler states:

scheduler_states = llm_load(os.path.join(ckpt_path, "schedulder.pt"))

Maybe it's a better option to aggregate all constant variables into a single module and modify the file directly for global change?

https://github.com/huggingface/transformers/blob/efdd436663436e78d8ad3213d11325d86578db95/src/transformers/trainer.py#L246-L253

@Spico197 Spico197 added the question Further information is requested label Feb 20, 2024
@mwiacx
Copy link
Contributor

mwiacx commented Feb 23, 2024

@SolenoidWGT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants