Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSlider uses frame glow color when selected instead of glow color. #464

Open
Pconti31 opened this issue Apr 17, 2022 · 0 comments
Open

XSlider uses frame glow color when selected instead of glow color. #464

Pconti31 opened this issue Apr 17, 2022 · 0 comments

Comments

@Pconti31
Copy link
Contributor

Testing XSlider with themes shows that the current XSlider is incorrectly using frame glow color from the
gslc_ElemCalcRectState() routine when drawing the track.

inside gslc_ElemCalcRectState() 
// Calculate the element colors
  pState->colBack = pElem->colElemFill;
  if (bGlowing) {
    pState->colFrm = pElem->colElemFrameGlow;
    pState->colInner = pElem->colElemFillGlow; <-- maybe use this instead???
    pState->colTxtFore = pElem->colElemTextGlow;
  } else {
    pState->colFrm = pElem->colElemFrame;
    pState->colInner = pElem->colElemFill;
    pState->colTxtFore = pElem->colElemText;
  }

inside XSlider Draw
    // Make the track highlight during glow
    gslc_DrawLine(pGui,nX0+nMargin,nYMid,nX1-nMargin,nYMid,sState.colFrm);

Note that the builder currently doesn't even ask for frame glow colors on any elements although that could change in the future.

One more issue when touching the slider a large black box is briefly shown to refresh the controls. Might be nicer if we had a way to set the color beside you using the background since in many cases we have an enclosing box for our controls with a different color than the background.
Paul--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant