Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Different array lengths in v2 44k configs #428

Open
Tps-F opened this issue May 12, 2024 · 0 comments
Open

[WIP] Different array lengths in v2 44k configs #428

Tps-F opened this issue May 12, 2024 · 0 comments

Comments

@Tps-F
Copy link
Contributor

Tps-F commented May 12, 2024

TL;DR

44k json config maybe broken. It looks like v1 architecture.
Fix PR: #427

Codes

"upsample_rates": [8, 8, 2, 2, 2],
"upsample_initial_channel": 512,
"upsample_kernel_sizes": [16, 16, 4, 4, 4],

in L43 and L45, I think four array lengths is correct.

self.num_upsamples = len(upsample_rates)

and that may makes the length here wrong.

for i, (u, k) in enumerate(zip(upsample_rates, upsample_kernel_sizes)):
self.ups.append(
weight_norm(
ConvTranspose1d(
upsample_initial_channel // (2**i),
upsample_initial_channel // (2 ** (i + 1)),
k,
u,
padding=(k - u) // 2,
)
)
)

Convolutional Neural Network is also broken.

self.dec = GeneratorNSF(
inter_channels,
resblock,
resblock_kernel_sizes,
resblock_dilation_sizes,
upsample_rates,
upsample_initial_channel,
upsample_kernel_sizes,
gin_channels=gin_channels,
sr=sr,
is_half=kwargs["is_half"],
)

These generators will also be affected.

@blaise-tk blaise-tk pinned this issue May 20, 2024
@blaise-tk blaise-tk changed the title [Bug]Different array lengths in v2 44k configs [WIP] Different array lengths in v2 44k configs May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant