Fix cancellation of drag actions in all tools where it's missing #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keavon everything but the filltool (and artboardtool which is in a separate PR) should be fixed by this PR. I plan on maybe refactoring the solution in ArtBoardTool based on what I learnt from other tools (nothing serious, just removing a long pattern match with a MessageDiscriminant) |
…ortTransaction while aborting select tool
Keavon
force-pushed
the
abortable-drag-actions
branch
from
eb1acd2
to
4d271b2
Compare
Keavon
approved these changes
Mar 10, 2024
Keavon
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1657, closes #1663
A bigger PR focused on fixing multiple tools at once along with other issues discovered.