Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Chart Time Series Hovering Performance #4442

Open
liversedge opened this issue Feb 2, 2024 · 1 comment
Open

User Chart Time Series Hovering Performance #4442

liversedge opened this issue Feb 2, 2024 · 1 comment
Assignees
Milestone

Comments

@liversedge
Copy link
Member

liversedge commented Feb 2, 2024

When hovering over a time series user chart the performance can be poor and cpu usage spikes.
This is particularly evident when the number of points are high for activities with 1s samples > 2-3hrs.

The scatter plot uses a quadtree to assist in mapping the mouse cursor to data points and is highly performant. But the time series not only uses lower_bound to search the entire series (and repeats this for EVERY series) it also takes a copy of data points to achieve it. (not sure why).

The code needs to be rewritten to consider performance since time series charts are the single most popular way of visualising activity data.

See code at GenericSelectTool:681-723

@liversedge liversedge self-assigned this Feb 2, 2024
@liversedge liversedge added this to the 3.7 milestone Feb 2, 2024
@liversedge
Copy link
Member Author

Weirdly the performance is much better when the sidebar is being shown.
It is not at all clear why this is the case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant