Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

[Feature Request] add support for BottomSheetDialogFragment #82

Open
k0shk0sh opened this issue Apr 15, 2017 · 5 comments
Open

[Feature Request] add support for BottomSheetDialogFragment #82

k0shk0sh opened this issue Apr 15, 2017 · 5 comments

Comments

@k0shk0sh
Copy link
Contributor

It'd be cool if BottomSheetDialogFragment is supported out of the box.

Looking forward for the next release 馃憤

@iffa
Copy link

iffa commented Apr 19, 2017

All you have to do is add this and you have turned your standard DialogFragment into a BottomSheetDialogFragment 馃槃

@k0shk0sh
Copy link
Contributor Author

@iffa well that's genius, I really didn't give it a thought lol.
Thanks

@k0shk0sh
Copy link
Contributor Author

k0shk0sh commented Apr 20, 2017

@passsy I guess this could be closed, however it might be good to include this workaround some where.

@passsy
Copy link
Contributor

passsy commented May 4, 2017

We will not provide a TiBottomSheetDialogFragment because it would require a new dependency. But I'll leave it open because we could support composition instead of inheritance in the future without using CompositeAndroid.

ActivityLifecycleCallbacks & FragmentLifecycleCallbacks 馃殌

@k0shk0sh
Copy link
Contributor Author

k0shk0sh commented May 5, 2017

@passsy make sense, but the workaround solution posted here is actually pretty easy to implement and one could use it without writing plenty of code, I guess it would be cool if its documented somewhere for others to notice because now bottomSheets are the new Dialogs .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants