TechDraw dimemsion repair inconsistent selection with greedy selection

[johnsonm]

Is there an existing issue for this?

• I have searched the existing issues

Problem description

When using TechDraw_DimensionRepair, after clicking "OK" to apply a repair, the repaired dimension is selected in the tree, but not in the drawing (it is no longer green to indicate that it is selected).

With greedy selection, and multiple dimensions to repair, I then click on another dimension to select it, click to repair, and select the correct references, click "OK", and the previous dimension is what was actually being modified and is then updated.

Even though nothing is showing as selected in the document (nothing is green), I still have to first click the background to deselect the dimension in the model tree, then click on the dimension to repair, in order to actually repair it.

For example, loading https://gitlab.com/mcdanlj/RotaryBroach/-/raw/main/RotaryBroachParts.FCStd?ref_type=heads&inline=false and repairing references on BodyBoreOpsPage, I can have (as here) have just repaired Dimension007, then select Dimension001 on the page, silently leaving both Dimension0001 and Dimension007 selected in the tree, and Dimension007 the one actually chosen to repair. If I don't notice that, then when I replace the references, the wrong dimension changes.

When finishing a repair, either de-selecting the repaired dimension in the tree or re-synchronizing the view in the page to the selections would avoid this problem. It would be better to de-select the repaired dimension in the tree because if TechDraw_DimensionRepair is required at all, it is probably required for multiple dimensions, therefore the workflow is probably repairing multiple dimensions in a row, and having to explicitly deselect is additional and unnecessary work.

Full version info

OS: Debian GNU/Linux 12 (bookworm) (GNOME/gnome)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37308 (Git)
Build type: Unknown
Branch: main
Hash: b72a8c4222e74205fcbc181efc2d3182e8c59da5
Python 3.11.2, Qt 5.15.8, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Assembly4 0.50.4
  * Curves 0.6.13
  * sheetmetal 0.3.0
  * ExplodedAssembly
  * fasteners 0.4.66
  * MeshRemodel 1.8919.0
  * freecad.gears 1.0.0
  * Pyramids-and-Polyhedrons
  * dxf_library
  * lattice2 1.0.0
  * boltsfc 2022.11.5
  * in3dca-freegrid 2.0.0
  * parts_library
  * Defeaturing 1.2.0
  * A2plus 0.4.60n
  * CurvedShapes 1.0.4
  * Manipulator 1.5.0
  * Pyramids-and-Polyhedrons.backup1696298372.5270553 (Disabled)
  * Assembly3 0.12.2

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[WandererFan]

<<With greedy selection, and multiple dimensions to repair, I then click on another dimension to select it, click to repair, and select the correct references, click "OK", and the previous dimension is what was actually being modified and is then updated.>>

On exit from DimRepair, the original selected dimension is still in the selection list (don't know why it isn't green yet) and greedy selection adds the second dimension to the end of the selection. When you start the 2nd repair task, it takes the first dimension in the selection as the subject.

I don't think clearing the selection on exit from DimRepair will cause any issues.

[johnsonm]

I agree, clearing the selection on exit works better. Thank you!

[Edit: Honoring greedy selection in TechDraw is #14052]