Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Assembly: Std_LinkSelectLinked and Std_LinkSelectLinkedFinal are hard to reach #12167

Closed
2 tasks done
pierreporte opened this issue Jan 28, 2024 · 4 comments · Fixed by #14032
Closed
2 tasks done
Labels
WB Assembly Related to the Integrated Assembly Workbench

Comments

@pierreporte
Copy link

pierreporte commented Jan 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

In the assembly workbench, Std_LinkSelectLinked and Std_LinkSelectLinkedFinal are used to open a part or sub-assembly in a dedicated tab. This is a common action when working on an assembly. The two commands are located in the Link actions entry of the context menu. Depending on what is right-clicked (tree view entry, a part in the 3D view), it changes position.

The commands should be at the top level of the context menu and in the assembly toolbar.

Full version info

0.22

Subproject(s) affected?

Assembly

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added the WB Assembly Related to the Integrated Assembly Workbench label Feb 1, 2024
@PaddleStroke
Copy link
Contributor

PaddleStroke commented Feb 26, 2024

image
Indeed the menu entries are not consistent.

I would suggest moving Std_LinkSelectLinked to the top of the contextual menu when the selection is an external link. I would even say make it the default action of double click (when there is no edit action) rather than having transform as the default.
The contextual menu of tree and objects need some work btw... They are indeed not very consistent of logical.

I wouldn't say this needs to be in the toolbar though. Only in the correct place of contextual menu seems correct.

@pierreporte
Copy link
Author

I would even say make it the default action of double click

No please. In CAD program, this usually enters the edit mode of the part. I actually asked this for part design but it should be more general. See #11429.

@pierreporte
Copy link
Author

I would add, following the #12165 fix, that the commands should be called “Open component in a new tab” or something similar.

@pierreporte
Copy link
Author

@maxwxyz You may be interested in this since you work on improving context menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants