You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a check invokes the asArray() method more than once then the healthCheck.name value will keep getting prefixed to the start of the new check name, resulting in check names such as:
Backend key: Backend key: The shared backend key has been rotated recently
when the desired result is:
Backend key: The shared backend key has been rotated recently
The preferred solution would be to fix this issue at source and allow asArray() to be invoked multiple times without affecting the state of the Check class instances property values.
The text was updated successfully, but these errors were encountered:
The
categoryInCheckName
function that appears in these lines and below mutates the state of the Check class instance (thecheck
argument).If a check invokes the
asArray()
method more than once then thehealthCheck.name
value will keep getting prefixed to the start of the new check name, resulting in check names such as:Backend key: Backend key: The shared backend key has been rotated recently
when the desired result is:
Backend key: The shared backend key has been rotated recently
There are legitimate reasons why
asArray()
may be called twice and cause this effect - this was happening innext-health
and was fixed by this PR: https://github.com/Financial-Times/next-health/pull/360.The preferred solution would be to fix this issue at source and allow
asArray()
to be invoked multiple times without affecting the state of the Check class instances property values.The text was updated successfully, but these errors were encountered: