Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Batching] Concerns about whether features are not supported using Medusa #82

Open
Ageliss opened this issue Feb 21, 2024 · 0 comments

Comments

@Ageliss
Copy link

Ageliss commented Feb 21, 2024

I checked the TRT-LLM but found something confusing. There are some features not supported:

  1. inferece batch size == 1, (seemed solved recently)
  2. not surport in-flight batching, which will be a great concern since this feature greatly improve thorouput
  3. temperature == 0, how about temperature > 0?
  4. kv_cache, I guess kv_cache needed recompute because generate_tokens will > 1

My biggest concern is whether Medusa2 conflicts with in-flight batching?

image

@Ageliss Ageliss changed the title [Dynamic Batching] Concers about what features are not supported using Medusa [Dynamic Batching] Concerns about whether features are not supported using Medusa Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant